fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.1 #5643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.3.0
->v0.3.1
Release Notes
cyphar/filepath-securejoin (github.com/cyphar/filepath-securejoin)
v0.3.1
Compare Source
By allowing
Open(at)InRoot
to opt-out of the extra work done byMkdirAll
to do the necessary "partial lookups",
Open(at)InRoot
now does less workfor both implementations (resulting in a many-fold decrease in the number of
operations for
openat2
, and a modest improvement for non-openat2
) and isfar more guaranteed to match the correct
openat2(RESOLVE_IN_ROOT)
behaviour.
We now use
readlinkat(fd, "")
where possible. ForOpen(at)InRoot
thiseffectively just means that we no longer risk getting spurious errors during
rename races. However, for our hardened procfs handler, this in theory should
prevent mount attacks from tricking us when doing magic-link readlinks (even
when using the unsafe host
/proc
handle). UnfortunatelyReopen
is stillpotentially vulnerable to those kinds of somewhat-esoteric attacks.
Technically this will only work on post-2.6.39 kernels
but it seems incredibly unlikely anyone is using
filepath-securejoin
on apre-2011 kernel.
Several improvements were made to the errors returned by
Open(at)InRoot
andMkdirAll
when dealing with invalid paths under the emulated (ie.non-
openat2
) implementation. Previously, some paths would return the wrongerror (
ENOENT
when the last component was a non-directory), and other pathswould be returned as though they were acceptable (trailing-slash components
after a non-directory would be ignored by
Open(at)InRoot
).These changes were done to match
openat2
's behaviour and purely is aconsistency fix (most users are going to be using
openat2
anyway).Signed-off-by: Aleksa Sarai cyphar@cyphar.com
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.