Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.33] Bump go-jose CVE-2024-28180 #5482

Conversation

TomSweeneyRedHat
Copy link
Member

This is the second PR to fix this CVE. In one of the Skopeo PR's, @mtrmac pointed out that was a second go-jose module, gopkg.in/go-jose/go-jose which also had to be bumped. This does that.

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

This is the second PR to fix this CVE. In one of the Skopeo PR's, @mtrmac pointed out that was a second go-jose module, gopkg.in/go-jose/go-jose which also had to be bumped. This does that.

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Apr 20, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TomSweeneyRedHat,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 997beea into containers:release-1.33 Apr 20, 2024
34 of 36 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants