-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix links to containerignore doc #5402
fix links to containerignore doc #5402
Conversation
Signed-off-by: Philippe Vlérick <pvlerick@gmail.com>
docs/buildah-add.1.md
Outdated
@@ -89,7 +89,7 @@ buildah add containerID 'passwd' 'certs.d' /etc | |||
|
|||
## FILES | |||
|
|||
### .containerignore | |||
### .containerignore/.dockerignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a path on quick look maybe make it .containerignore or .dockerignore
. Anyways is there any need to include .dockerignore
in this heading ? I think the text below describes talks about .dockerignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit above otherwise PR LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the nit is cleansed.
Co-authored-by: Tom Sweeney <tsweeney@redhat.com> Signed-off-by: Philippe Vlérick <pvlerick@gmail.com>
Suggestion applied. FYI, I aligned it with what I could find here: https://github.com/containers/podman/blob/main/docs/source/markdown/podman-build.1.md.in#L635 |
BTW no comment on the ignore files priorities discrepancies between the doc and the code ? :-) |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Pvlerick, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documentation
How to verify it
N/A
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
In the selection of the ignore file, the logic is wrong; the comment here https://github.com/containers/buildah/blob/main/pkg/parse/parse.go#L1290 says that .containerignore will be preferend but the code obviously does the opposite since the .dockerignore is checked for in the second if.
Proving test: https://github.com/Pvlerick/buildah/blob/container-ignore-file-priority/pkg/parse/parse_test.go#L233
However, changing this logic is a breaking change, and this [file].dockerignore/[file].containerignore is not documented (at least I didn't find any mention of it)
Does this PR introduce a user-facing change?
NO