Bump c/* projects, Buildah to v1.35.0 and then to v1.36.0-dev #5385
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
internal/mkcw/embed/entrypoint_amd64
Outdated
There was a problem hiding this comment.
This should not be commited AFAIK, no idea why this is not in gitignore
There was a problem hiding this comment.
They are not in .gitignore so that Buildah builds on non-x86 platforms where the tools to recreate them are not available. (That is a decision which could be revisited.)
WRT the details of the changes, compare #5280 (comment) ; I didn’t (yet?) compare the files in this PR.
There was a problem hiding this comment.
But these files are new and not committed yet at all https://github.com/containers/buildah/tree/main/internal/mkcw/embed, only the source and the compressed binary are committed.
There was a problem hiding this comment.
My mistake, you are completely correct.
AFAICS 3b795dd renamed the files but did not update .gitignore.
There was a problem hiding this comment.
#5389 should prevent this for the future.
There was a problem hiding this comment.
I've removed this and the other internal/mkcw/embed/entrypoint file that was added.
Huh, #5382 is succeeding in this respect, and I can’t see that c/common should change much. It might be productive to merge #5382 first, to decrease the amount of changes to analyze. My guess is that the conformance test digest computation needs something vaguely like https://github.com/containers/storage/blob/2a79830a222670cd559a264b402cd6a151ab6bc5/pkg/chunked/compressor/compressor.go#L418-L429 to read all trailing zeroes, but I can’t see any reason why that should start only failing in this PR. |
ae6f7d9 to
fb5c0cb
Compare
As the title says. Bump: c/common v0.58.0 c/image v5.30.0 c/storage v1.53.0 In preparation for Podman v5.0 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Bump to Buildah v1.35.0 in preparation of Podman v5.0. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says. Bumping back to the next dev version. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
fb5c0cb to
da81d2e
Compare
|
/lgtm |
The fourth step in the vendor dance for Podman v5.0.
Bump:
c/storage v1.53.0
c/image v5.30.0
c/common v0.58.0
c/Buildah v1.35.0
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?