Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two minor patches #547

Merged
merged 2 commits into from
May 20, 2024
Merged

two minor patches #547

merged 2 commits into from
May 20, 2024

Conversation

cgwalters
Copy link
Collaborator

Colin Walters (2):
hack: Also support --build-arg=base=
lib: Run cargo fmt

cgwalters added 2 commits May 17, 2024 16:40
Let's make it also easy to build using fedora.

Signed-off-by: Colin Walters <walters@verbum.org>
Our CI seems to have missed this because we weren't doing
`cargo fmt` with all features enabled.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters force-pushed the hack-c9s-or-fedora branch from 55174d7 to 950110c Compare May 17, 2024 20:40
@jeckersb jeckersb self-assigned this May 20, 2024
Copy link
Contributor

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeckersb jeckersb merged commit 11473f7 into containers:main May 20, 2024
16 of 18 checks passed
jeckersb added a commit to jeckersb/bootc that referenced this pull request May 21, 2024
Same as containers#547, but I'm not sure how this instance wasn't caught
previously.

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb jeckersb mentioned this pull request May 21, 2024
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
cgwalters added a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
…-deploy-integration-test

container: Add dir container deploy test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants