Make sure ilab wrapper is executable and in path #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
training/nvidia-bootc/Containerfile
Outdated
| fi | ||
| fi \ | ||
| && chmod +x /usr/local/bin/ilab \ | ||
| && echo 'PATH=$PATH:/usr/local/bin' > /etc/profile.d/usrlocalbin.sh |
There was a problem hiding this comment.
I was under the assumption /usr/local/bin is in the default $PATH so when the OS is installed via the bootc container it should be there. Is this assumption incorrect?
There was a problem hiding this comment.
It is for users, but not for root, and IIRC ilab should be run as root
[cloud-user@javipolo-rhel-ai-0705a ~]$ echo $PATH
/var/home/cloud-user/.local/bin:/var/home/cloud-user/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
[cloud-user@javipolo-rhel-ai-0705a ~]$ sudo -i
[root@javipolo-rhel-ai-0705a ~]# echo $PATH
/usr/local/sbin:/sbin:/bin:/usr/sbin:/usr/bin
There was a problem hiding this comment.
Why not install ibal in /usr/bin/ ?usr/local should not be used.
There was a problem hiding this comment.
I just changed the commit to copy to /usr/bin and stop using /usr/local/bin
Signed-off-by: Javi Polo <jpolo@redhat.com>
e821527 to
2d269cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.