Add BASEIMAGE as argument to Containerfile #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added BASEIMAGE as ARG so it can be used from build. Signed-off-by: Enrique Belarte Luque <ebelarte@redhat.com>
|
This is what the echo "FROM scratch" > Containerfile
podman build --from="registry.redhat.io/ubi9/ubi:latest" . -f Containerfile -t testing
STEP 1/1: FROM registry.redhat.io/ubi9/ubi:latest
COMMIT testing
--> 261134d03e83
Successfully tagged localhost/testing:latest
Successfully tagged registry.redhat.io/ubi9/ubi:latest
Successfully tagged registry.access.redhat.com/ubi9/ubi:latest
261134d03e83034da5dce51c49a45807633c79aa4355c9d57ff7d452a649aa7cFeel free to read more about this in the podman docs. If, knowing all this, there is some reason to keep this as a separate build arg instead of from please let me know. |
|
Konflux CI takes Containerfile and builds it with its own pipeline where unless I'm mistaken we can only use build-args. Hence the change. It is done this way on others. |
|
Are you planning on opening similar PRs for invidia-bootc and intel-bootc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BASEIMAGE as ARG so it can be used from build.