Windows: Add runtime DNS and del bug fix #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like travis failed out, possible to retest? |
pjh
added a commit
to yujuhong/gce-k8s-windows-testing
that referenced
this pull request
Mar 6, 2019
pjh
added a commit
to yujuhong/gce-k8s-windows-testing
that referenced
this pull request
Mar 6, 2019
See kubernetes/kubernetes#74759 (comment) for some context. Steps to build the .zip file in the containernetworking/plugins directory: git checkout master git pull git checkout -b patch-271 git remote add nagiesek https://github.com/nagiesek/plugins git fetch nagiesek git cherry-pick 7a3231e9c636585e505ec240647e63bfcaa78656 ./build_windows.sh zip windows-cni-plugins.zip bin/*.exe
pjh
added a commit
to yujuhong/gce-k8s-windows-testing
that referenced
this pull request
Mar 6, 2019
Update CNI plugins with containernetworking/plugins/pull/271.
squeed
reviewed
Mar 6, 2019
This adds the dns capability for supplying a runtime dnsConfig from a CRI. It also includes a bug fix for removing an endpoint when no IPAM is supplied. Adds version dependency of 0.3.0. Mild updates to windows READMEs.
7a3231e to
b71e8db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dns capability for supplying a runtime dnsConfig from a CRI. It also includes a bug fix for removing an endpoint when no IPAM is supplied.