[ON HOLD] Disable TestIPFSComposeUp

[apostasie]

This test is failing a lot.

Even despite the fact that we do retry all tests, it still regularly fail builds, with a variety of different errors (cannot start a stopped container, reuse of closed network connections, etc).

While it is unclear whether the test or the underlying code is faulty, and despite some time spent investigating it with no success, this test serves no purpose given its current condition, and there does not seem to be interest in fixing it.

Suggesting we disable it.

[AkihiroSuda]

Needs a link to the github issue w/ failure logs

[ktock]

I'm trying to reproduce this flakiness on GitHub Actions but I can't reproduce this (passed 3 times / 3 attemptions). 🤔

[apostasie]

Thanks a lot for looking into this @ktock.

Here are a couple of links with potentially more info:

• first noticed by yankay flaky test: Error establishing a database connection in CI  #2690
• this PR does disable test retries, which are hiding failures - much easier to repro without the restarts: [FLAKY DEBUG, NO RETRIES] Current focus: IPFS/Compose failure #3305

One example of failure on the above happening after a couple of tries: https://github.com/containerd/nerdctl/actions/runs/10433233259/job/28894754561?pr=3305#step:7:531

It also happens regularly on normal PRs:
#3293 (comment)

unfortunately not sure how to access the logs of this one ^ since we manually restarted it.

Will send more as soon as we hit it again.

[apostasie]

I'm trying to reproduce this flakiness on GitHub Actions but I can't reproduce this (passed 3 times / 3 attemptions). 🤔

I still think we should remove the retries entirely: #3400

It would be extremely painful for a few weeks, but we would be much better off in the long run...

[apostasie]

@ktock I just hit the "cannot start a stopped container" variant of it:

https://github.com/containerd/nerdctl/actions/runs/10690479035/job/29634950871

=== RUN   TestIPFSComposeUp/ipfs-address
    testing_linux.go:186: projectName="nerdctl-compose-test3949339011"
    testing_linux.go:188: assertion failed: res.ExitCode is not exitCode: 
        Command:  /usr/local/bin/nerdctl --namespace=nerdctl-test compose -f /tmp/nerdctl-compose-test3949339011/docker-compose.yaml --ipfs-address=/ip4/10.4.0.1/tcp/5000 up -d
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   time="2024-09-03T21:19:34Z" level=warning msg="/tmp/nerdctl-compose-test3949339011/docker-compose.yaml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion"
        time="2024-09-03T21:19:34Z" level=info msg="Creating network nerdctl-compose-test3949339011_default"
        time="2024-09-03T21:19:34Z" level=info msg="Creating volume nerdctl-compose-test3949339011_db"
        time="2024-09-03T21:19:34Z" level=info msg="Creating volume nerdctl-compose-test3949339011_wordpress"
        time="2024-09-03T21:19:34Z" level=info msg="Ensuring image ipfs://bafkreif7vyfj36wyyzxi42pmcor57gamp73mh2cwtjzhio5gukoocu54ku"
        time="2024-09-03T21:19:34Z" level=info msg="Ensuring image ipfs://bafkreiep3tl4cxkt4mlhzjil24cgzi7bqcwckxjm7fy6cx7nnqh56idl44"
        time="2024-09-03T21:19:34Z" level=info msg="Creating container nerdctl-compose-test3949339011-db-1"
        time="2024-09-03T21:19:34Z" level=warning msg="volume \"nerdctl-compose-test3949339011_db\" already exists and will be returned as-is"
        time="2024-09-03T21:19:34Z" level=fatal msg="OCI runtime start failed: cannot start a container that has stopped: unknown"
        time="2024-09-03T21:19:34Z" level=fatal msg="error while creating container nerdctl-compose-test3949339011-db-1: exit status 1"
        
        
--- FAIL: TestIPFSComposeUp/ipfs-address (7.16s)
FAIL cmd/nerdctl/ipfs.TestIPFSComposeUp/ipfs-address (7.16s)
=== RUN   TestIPFSComposeUp
--- FAIL: TestIPFSComposeUp (163.63s)

[apostasie]

@ktock another one is here:

• https://github.com/containerd/nerdctl/actions/runs/10535910757/job/29195492468

[apostasie]

https://github.com/containerd/nerdctl/actions/runs/10931205479/job/30345687262?pr=3435#step:7:822

[apostasie]

Another one:
https://github.com/containerd/nerdctl/actions/runs/10931614269/job/30356848461?pr=3435#step:6:784

[apostasie]

@ktock were you able to reproduce this locally?

[apostasie]

@ktock any update?

[apostasie]

• [rootless] bridge network degrading ending in failure to expose port #3488
• IPFS: layer not found - follow-up to #3425 #3489

[apostasie]

@ktock @AkihiroSuda I have a local version (with #3490 + custom cni plugins + rewritten tests) and had it run 100+ times without breaking (I had to disable some estargz tests though - they are currently passing only because of side effects with other tests - see #3475).

I will send the rest of the changes for review later on.

In the meantime, closing this.