Kubernetes minor cleanup (rename and -f on delete) #3338
Merged
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds less clear in my feeling |
@AkihiroSuda what about just "kubernetes"? That avoids the possible confusion with kubectl that fahedouch was probably wary of, and is better than k8s. |
|
SGTM |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
7b357fc to
031aa1d
Compare
Ok, should be fine, but let's wait for the kubernetes action to finish. |
|
Failure is unrelated ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address @fahedouch belated comments on #3296
Specifically:
-fto kubectl delete to speed up the teardown routinePTAL at your convenience.