-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround flaky save #3179
Workaround flaky save #3179
Conversation
Ok, let's not jinx it, but for me locally, it DOES fix #2327 and with four pushes, we never failed once the dreaded I am convinced the underlying issue is still here though - I also reproduced it with nerdcl/mod-v2 & containerd-v2 - so, it is here to stay. @AkihiroSuda I suggest we merge this ASAP. Worse case scenario it does nothing (this is good hygiene anyway to have that in a separate namespace). Best case scenario, it does make our lives significantly better... Tagging @yankay and @fahedouch - who had some discussion about the underlying issue in #2327 . For good measure, I am namespacing as well the other save tests. |
c8e0204
to
9935520
Compare
Please squash the commits, then LGTM |
9935520
to
ecf7dac
Compare
@AkihiroSuda done. Thanks. |
Wait. Something wrong with the project checks? |
Ok, so. Whitespaces "issues" have been flagged in my commit about The reason it did escape us is that we recently disabled running CI test for markdown-only changes... I'll take care of the CI right now (splitting out project checks and re-enabling them for md files changes) Sorry about this mess. |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
ecf7dac
to
faa28f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Let's see what the CI says...
This one has been driving me bonkers for a while.
The issue is obviously still here (and I believe it is a containerd bug), but the workaround seems to work.