Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add retry on github action #3024

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

yankay
Copy link
Contributor

@yankay yankay commented May 20, 2024

Some flaky tests make the GitHub action fail pretty often.

The developer needs to retry the test several times to make it successful.

So, add a retry on GitHub action to make the development work more effectively.

@yankay yankay force-pushed the add-retry-on-test branch from b474a69 to b0814e4 Compare May 20, 2024 12:25
@yankay yankay changed the title ci: Add retry on github action [WIP]ci: Add retry on github action May 20, 2024
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the add-retry-on-test branch from b0814e4 to 713851d Compare May 20, 2024 12:46
@yankay yankay changed the title [WIP]ci: Add retry on github action ci: Add retry on github action May 20, 2024
@pendo324
Copy link
Contributor

Are we considering this a solution to the 2 issues, or a temporary workaround until we have time to investigate why the tests are flaky?

@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label May 20, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone May 20, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Ideally, we should revert this eventually

@AkihiroSuda AkihiroSuda merged commit 88cb67b into containerd:main May 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants