Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on github.com/hashicorp/go-multierror #2434

Merged

Conversation

AkihiroSuda
Copy link
Member

No description provided.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v1.5.1 (tentative) milestone Aug 11, 2023
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit 61b0fcf into containerd:main Aug 11, 2023
@djdongjin
Copy link
Member

One behavior difference between multierror.Append and errors.Join is that the former will append to an existing multierror if it is (so the new one has a length of N + 1), while the latter will create a new joinError which includes previous error and the new one (so the new one has a length of 2)

https://go.dev/play/p/ryeimUucDyb

I feel the expected use pattern of errors.Join is to have a errs [] error to save all the errors along the way and a errors.Join(errs...) at the end to produce one joinError.

golang/go#60209

golang/go#53435 (comment)

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Aug 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants