Merge pull request #2619 from AkihiroSuda/fix-2598

nerdctl ps: implement `--format {{.Label "foo"}}`

cmd/nerdctl/container_list.go

@@ -191,7 +191,7 @@ func formatAndPrintContainerInfo(containers []container.ListItem, options Format
 	for _, c := range containers {
 		if tmpl != nil {
 			var b bytes.Buffer
-			if err := tmpl.Execute(&b, c); err != nil {
+			if err := tmpl.Execute(&b, &c); err != nil {
 				return err
 			}
 			if _, err := fmt.Fprintln(w, b.String()); err != nil {

cmd/nerdctl/container_list_test.go

@@ -0,0 +1,43 @@
+/*
+   Copyright The containerd Authors.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+
+package main
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/containerd/nerdctl/pkg/testutil"
+)
+
+// https://github.com/containerd/nerdctl/issues/2598
+func TestContainerListWithFormatLabel(t *testing.T) {
+	t.Parallel()
+	base := testutil.NewBase(t)
+	tID := testutil.Identifier(t)
+	cID := tID
+	labelK := "label-key-" + tID
+	labelV := "label-value-" + tID
+
+	base.Cmd("run", "-d",
+		"--name", cID,
+		"--label", labelK+"="+labelV,
+		testutil.CommonImage, "sleep", "infinity").AssertOK()
+	defer base.Cmd("rm", "-f", cID).AssertOK()
+	base.Cmd("ps", "-a",
+		"--filter", "label="+labelK,
+		"--format", fmt.Sprintf("{{.Label %q}}", labelK)).AssertOutExactly(labelV + "\n")
+}

pkg/cmd/container/list.go

@@ -101,6 +101,10 @@ type ListItem struct {
 	// TODO: "LocalVolumes", "Mounts", "Networks", "RunningFor", "State"
 }
 
+func (x *ListItem) Label(s string) string {
+	return x.Labels[s]
+}
+
 func prepareContainers(ctx context.Context, client *containerd.Client, containers []containerd.Container, options types.ContainerListOptions) ([]ListItem, error) {
 	listItems := make([]ListItem, len(containers))
 	for i, c := range containers {