Skip to content

Commit

Permalink
Merge pull request #3374 from apostasie/chore-kube-grrrr
Browse files Browse the repository at this point in the history
Disable flaky #827 test
  • Loading branch information
AkihiroSuda authored Aug 28, 2024
2 parents c490934 + 68be0ce commit 4ab2866
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions cmd/nerdctl/container_commit_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,18 @@ import (
"github.com/containerd/nerdctl/v2/pkg/testutil"
)

/*
This test below is meant to assert that https://github.com/containerd/nerdctl/issues/827 is NOT fixed.
Obviously, once we fix the issue, it should be replaced by something that assert it works.
Unfortunately, this is flaky.
It will regularly succeed or fail, making random PR fail the Kube check.
*/

func TestKubeCommitPush(t *testing.T) {
t.Parallel()

t.Skip("Test that confirm that #827 is still broken is too flaky")

base := testutil.NewBaseForKubernetes(t)
tID := testutil.Identifier(t)

Expand Down Expand Up @@ -62,6 +71,7 @@ func TestKubeCommitPush(t *testing.T) {
"change the expectation to 'success'.")

base.Cmd("commit", containerID, "registry.example.com/my-app:v1").AssertOK()
// See note above.
base.Cmd("push", "registry.example.com/my-app:v1").Assert(icmd.Expected{
ExitCode: 1,
Err: "failed to create a tmp single-platform image",
Expand Down

0 comments on commit 4ab2866

Please sign in to comment.