cmd/dist/fetch: address subtle concurrency bug #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the fetcher concurrently, the loop modifying the closed `base` parameter was causing urls from different digests to be returned randomly. We copy the the value and then modify it to make it work correctly. Luckily, we are using content addressable storage or this would have been undetectable. Signed-off-by: Stephen J Day <stephen.day@docker.com>
|
This one was fun! |
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 62.12% 62.12%
=======================================
Files 3 3
Lines 404 404
=======================================
Hits 251 251
Misses 93 93
Partials 60 60Continue to review full report at Codecov.
|
|
I'm merging this to keep moving. If anyone objects, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the fetcher concurrently, the loop modifying the closed
baseparameter was causing urls from different digests to be returnedrandomly. We copy the the value and then modify it to make it work
correctly.
Luckily, we are using content addressable storage or this would have
been undetectable.
Signed-off-by: Stephen J Day stephen.day@docker.com