Fix "library stubs not installed" mypy error #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging containerbuildsystem#920, mypy started to fail with: 'Library stubs not installed for "requests.packages.urllib3.util.retry"' Looking at the requests source code, it seems that urllib3 is imported ad-hoc in the packages module, so changing the import to urllib3 directly solved the issue. I still don't know what caused it originally, since the merge request was just a bump to the 'packaging' library. Signed-off-by: Bruno Pimentel <bpimente@redhat.com>
|
👍 Just solved it the same way for my PR..... |
mike-kingsbury
approved these changes
Oct 17, 2023
taylormadore
approved these changes
Oct 17, 2023
Merged
via the queue into
containerbuildsystem:master
with commit Oct 17, 2023
51f1967
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #920, mypy started to fail with:
'Library stubs not installed for "requests.packages.urllib3.util.retry"'
Looking at the requests source code, it seems that urllib3 is imported ad-hoc in the packages module, so changing the import to urllib3 directly solved the issue.
I still don't know what caused it originally, since the merge request was just a bump to the 'packaging' library.
Maintainers will complete the following section