-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm package-spec aliases are not handled correctly #859
Comments
Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
… builds (#937) Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Hello and thanks for the bug report @taylormadore is currently working on a major refactoring to support v3 package-lock.json: #857. I think this issue will be resolved as part of that, but we'll need to verify. |
FWIW, depending on |
Npm v9 support has been released. Aliases are now handled properly in lockfile versions 2 and 3 (npm 7+), but still break in lockfile version 1. Since your lockfile is version 2, aliases should work now 🎉 |
Downstream builds use an npmjs package caching system called cachito[1]. It currently does not support dependencies that use a package-spec alias[2][3]. Downgrading `rimraf` to version `^4.x` removed any aliases from our `package-lock.json` and should allow downstream builds to work again. [1] - https://github.com/containerbuildsystem/cachito [2] - https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases [3] - containerbuildsystem/cachito#859 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: ibolton336 <ibolton@redhat.com>
npm package-spec allows for aliases: https://docs.npmjs.com/cli/v9/using-npm/package-spec?v=true#aliases
This allows a dependency block to look like:
The corresponding
package-lock.json
will then look like:and the reference then looks like:
but cachito is attempting to download
string-width-cjs@npm:string-width-4.2.3.tgz
which will not exist in npmjs.Cachito should follow the alias before downloading.
The text was updated successfully, but these errors were encountered: