Add Secrets in NodeExpandVolumeRequest

[Sh4d1]

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Closes #445

cc @humblec

[humblec]

@Sh4d1 Thanks.. LGTM.

@gnufied @jsafrane @msau42 @xing-yang @saad-ali can we get some attention to this ? this become a blocker for different use cases of nodeExpansion.

[xing-yang]

How are you going to pass the secrets from the Kubernetes side? Does this require a change in Kubernetes API and also in external-provisioner like the following?

https://github.com/kubernetes/kubernetes/blob/v1.20.0-alpha.1/pkg/apis/core/types.go#L1656
https://github.com/kubernetes-csi/external-provisioner/blob/v2.0.2/pkg/controller/controller.go#L713

[Sh4d1]

@xing-yang yeah these changes would also be needed

[gnufied]

Okay lets open a issue in k/k repo for that. Do we expect node expansion secrets to be different from controller one? If yes - we will indeed need API change.

[humblec]

https://github.com/kubernetes-csi/external-provisioner/blob/v2.0.2/pkg/controller/controller.go#L713

Ack.. We need similar changes.. @xing-yang

Okay lets open a issue in k/k repo for that. Do we expect node expansion secrets to be different from controller one? If yes - we will indeed need API change.

@gnufied sure will do that.. NodeExpansion Secret can be same as "ControllerSecret" , I dont see a reason to have different one atleast for our use case.

[Sh4d1]

I agree with @humblec the secret should be the same.
@humblec do you open the issue on k/k?

[humblec]

I agree with @humblec the secret should be the same.
@humblec do you open the issue on k/k?

@Sh4d1 Sure.. here it is @kubernetes/kubernetes#95367

[gnufied]

cc @saad-ali @jdef

[saad-ali]

Please make sure you sign the CLA for CSI
See https://github.com/container-storage-interface/spec/blob/master/CONTRIBUTING.md#licence-and-cla

[Sh4d1]

Just sent out the CLA!

[saad-ali]

CLA confirmed! Thanks.
Please rebase this PR.

[Sh4d1]

Rebased!

[saad-ali]

Will merge as soon as 1.4.0 is cut (1.4.0-rc was cut earlier today and we're in a 72 hour waiting period). This will end up being part of 1.5.0

[saad-ali]

@jdef Any objections? If not, please feel free to merge.