Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds secrets field to ListSnapshotsRequest #372

Merged

Conversation

hakanmemisoglu
Copy link
Contributor

There is no way to directly pass credentials to ListSnapshots call.
This change will add a field required to pass credentials by the
caller.

@hakanmemisoglu
Copy link
Contributor Author

#370

@hakanmemisoglu
Copy link
Contributor Author

@saad-ali Do we need to update golang version in Travis? (or enable go module)

spec.md Outdated

// Secrets necessary for listing snapshots.
// This field is OPTIONAL. It can be used to pass secrets
// required to access some subset of the snapshots in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "some subset of the snapshots"? How is a subset defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about ... access the snapshots...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

  // Secrets required by plugin to complete ListSnapshot request.
  // This field is OPTIONAL. Refer to the `Secrets Requirements`
  // section on how to use this field.

@jieyu
Copy link
Member

jieyu commented Aug 7, 2019

Yeah, we should bump the golang in CI. It's still using 1.10.4

@hakanmemisoglu can you bump golang version in .travis.yml?

@hakanmemisoglu
Copy link
Contributor Author

@jieyu Sure. I will push a separate PR.

spec.md Outdated

// Secrets necessary for listing snapshots.
// This field is OPTIONAL. It can be used to pass secrets
// required to access some subset of the snapshots in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

  // Secrets required by plugin to complete ListSnapshot request.
  // This field is OPTIONAL. Refer to the `Secrets Requirements`
  // section on how to use this field.

Hakan Memisoglu added 4 commits August 13, 2019 15:37
There is no way to directly pass credentials to ListSnapshots call.
This change will add a field required to pass credentials by the
caller.
@hakanmemisoglu
Copy link
Contributor Author

@saad-ali CI passed.

Copy link
Member

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdef jdef merged commit c7ad51e into container-storage-interface:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants