-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds secrets field to ListSnapshotsRequest #372
Adds secrets field to ListSnapshotsRequest #372
Conversation
@saad-ali Do we need to update golang version in Travis? (or enable go module) |
spec.md
Outdated
|
||
// Secrets necessary for listing snapshots. | ||
// This field is OPTIONAL. It can be used to pass secrets | ||
// required to access some subset of the snapshots in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "some subset of the snapshots"? How is a subset defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about ... access the snapshots...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
// Secrets required by plugin to complete ListSnapshot request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
Yeah, we should bump the golang in CI. It's still using 1.10.4 @hakanmemisoglu can you bump golang version in .travis.yml? |
@jieyu Sure. I will push a separate PR. |
spec.md
Outdated
|
||
// Secrets necessary for listing snapshots. | ||
// This field is OPTIONAL. It can be used to pass secrets | ||
// required to access some subset of the snapshots in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
// Secrets required by plugin to complete ListSnapshot request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
There is no way to directly pass credentials to ListSnapshots call. This change will add a field required to pass credentials by the caller.
7d78bbe
to
b5361de
Compare
@saad-ali CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is no way to directly pass credentials to ListSnapshots call.
This change will add a field required to pass credentials by the
caller.