Adds secrets field to ListSnapshotsRequest #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saad-ali Do we need to update golang version in Travis? (or enable go module) |
xing-yang
reviewed
Aug 7, 2019
spec.md
Outdated
|
|
||
| // Secrets necessary for listing snapshots. | ||
| // This field is OPTIONAL. It can be used to pass secrets | ||
| // required to access some subset of the snapshots in the |
There was a problem hiding this comment.
What do you mean by "some subset of the snapshots"? How is a subset defined?
There was a problem hiding this comment.
How about ... access the snapshots...?
There was a problem hiding this comment.
How about:
// Secrets required by plugin to complete ListSnapshot request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
|
Yeah, we should bump the golang in CI. It's still using 1.10.4 @hakanmemisoglu can you bump golang version in .travis.yml? |
|
@jieyu Sure. I will push a separate PR. |
saad-ali
requested changes
Aug 7, 2019
spec.md
Outdated
|
|
||
| // Secrets necessary for listing snapshots. | ||
| // This field is OPTIONAL. It can be used to pass secrets | ||
| // required to access some subset of the snapshots in the |
There was a problem hiding this comment.
How about:
// Secrets required by plugin to complete ListSnapshot request.
// This field is OPTIONAL. Refer to the `Secrets Requirements`
// section on how to use this field.
added 4 commits
August 13, 2019 15:37
There is no way to directly pass credentials to ListSnapshots call. This change will add a field required to pass credentials by the caller.
7d78bbe to
b5361de
Compare
|
@saad-ali CI passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to directly pass credentials to ListSnapshots call.
This change will add a field required to pass credentials by the
caller.