Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (anilist): added fetch popular anime #41

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

JLdev0
Copy link
Contributor

@JLdev0 JLdev0 commented Aug 8, 2022

What kind of change does this PR introduce?
Allows you to fetch an array of popular anime from anilist

Did you add tests for your changes?
I'm the goat, so I not only added tests for fetch popular but also fetch trending (im the goat)
If relevant, did you update the documentation?
I forgot to, but then I read this and recommitted, so yes I updated the docs. goat vibes
Summary
You can now use fetchPopularAnime() to return an array of popular anime from anilist and change the page and number per page parameter.

I wanted this feature and asked Riimuru to do it but he told me to stop crying and to it myself.

WM-Screenshots-20220807171601
Other information
im the goat

Copy link
Contributor

@riimuru riimuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@riimuru riimuru merged commit 16e9716 into consumet:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants