fix(mixdrop): positive look-behind issue [iOS/Expo] #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS client-side bug on the web and/or Expo: causes issues with this extractor in the use cases described. This is due to an old spec. being supported in the case of iOS, and I am unsure in the case of Expo.
|
LGTM 👍 |
riimuru
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix for iOS/Expo when using consumet.ts library on the client side.
Did you add tests for your changes?
No; tested on https://regexr.com/ with multiple cases.
If relevant, did you update the documentation?
No need.
Summary
Positive look-behind regex breaks on iOS/Safari and Expo due to lack of support; @TDanks2000 and I worked out some fixes using other regular expressions to achieve the same result, so a big thanks to him!