Totally remove investment's internal_comments #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fa9908 to
5903ffb
Compare
40d1682 to
a360cf4
Compare
Internal comments on migration script from SpendingProposal to Investments are no longer in use, so removal is best option.
|
Tested in madrid production servers 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
As announced at
Deprecationsection of v0.13 releaseBecause of #2309 the Budget::Investment's
internal_commentscolumn got deprecated at #2404 in release v0.13. And a rake task was added to help migrate existing values on to the new internal valuation comments threadWe're getting rid of the database column in this release as all data should have been already migrated.
How
Screenshots
No need
Test
No need
Deployment
Please check that you've ran the migration rake task before considering deploying this to production
Warnings