Add publication date for milestones #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c123b66 to
1e1028d
Compare
bertocq
reviewed
Dec 14, 2017
| @@ -362,6 +362,7 @@ | |||
| association :investment, factory: :budget_investment | |||
| sequence(:title) { |n| "Budget investment milestone #{n} title" } | |||
| description 'Milestone description' | |||
| publication_date Time.zone.today | |||
There was a problem hiding this comment.
I assume this Time.zone.today works but Time.zone.today.to_date would be better?
There was a problem hiding this comment.
As far as I know, it would make no difference. to.date is only necessary for Capybara tests.
clairezed
pushed a commit
to CDJ11/CDJ
that referenced
this pull request
Jun 26, 2018
…-for-milestones Add publication date for milestones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
publication_dateattribute toBudget::Investment::Milestoneso end-users can tell when a milestone is achievedHow
publication_dateattribute intobudget_investment_milestonestableScreenshots
New milestone being created
Milestone created
Milestone shown to the end-user
Test