-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User recomendations #1776
Closed
Closed
User recomendations #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the recommended added truncate horizontal with css. Added link for each recommended. Adjusted for responsive. Passed scss-lint.
….Align text on the left. Used all width space for each container of the recomended.
… size of methods.
…proposals on recommendations.
We have apparently reached a postgres limit for the number of attributes we query. Using ids instead of the proposal objects seems to fix it Using `Array` and `map` instead of `pluck`, because the proposals attribute can be a single object
…ted to user interests
Some UX and technical improvements coming up for this PR. |
Merged
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Mar 18, 2019
…ing_proposals Migrate spending proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Show recommended proposals and debates to logged in users based in their interests.
How
Admin
Allow recommended module activation/deactivation on global settings form admin panel. Added new Setting key “feature.user.recommendations” to achieve this. Maybe some forks do not need this feature.
FrontEnd
1.a Use user interests if any (tags from followed objects) to get best user recommentations sorted by votes count
1.b Discard already followed object from recommendations
Screenshots
Partial recommendeds and link (1, 2)

Admin Panel (3)

Recommendations filter (4)

Test
Deployment
Remember we added next settings:
Setting['feature.user.recommendations'] = nil
Setting.create(key: 'feature.user.recommendations', value: "true")