-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for NaN fill values #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and the changes look good to me.
For some reason it fails a few tests though.
I will investigate this later and let you know what I find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one issue in the changes, I have fixed it in gdkrmr#1 and also
fixed another issue with the fillvalue and added a python unittest.
Once you merged that one, we can go ahead with this PR :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass (never mind appveyor, the tests always fail on PRs for some reason) now and this looks good to me. Let me know if everything works out with your tests for +/- inf, then I will merge.
Confirmed: Works from my side from R for NaNs, NAs, Inf, and -Inf 👍. I think this is ready to merge! |
Thanks for the contribution :). |
NaN
,Inf
and-Inf
as fill values. Tested with my R wrappers only forNaN
, I will test it forInf
tomorrow. Using NaN as fill value #148NaN
value to use, currently usingstd::numeric_limits<double>::quiet_NaN()
.