Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize destination query in router-publisher #5523

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: optimize destination query in router-publisher #5523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0be8b6
fix: no query unsupported destination transfers
wanglonghong Jan 10, 2024
77199cf
fix: !allowedDomains
wanglonghong Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/agents/router/src/tasks/publisher/operations/getXCalls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,17 @@ export const getXCalls = async () => {
}

if (txIdsByDestinationDomain.size > 0) {
// filter transfers by unsupported destination domain
for (const destinationDomain of txIdsByDestinationDomain.keys()) {
if (!allowedDomains.includes(destinationDomain)) {
const transferIdsToRemove = txIdsByDestinationDomain.get(destinationDomain);
for (const transferId of transferIdsToRemove ?? []) {
allTxById.delete(transferId);
}

txIdsByDestinationDomain.delete(destinationDomain);
}
}
const transfers = await subgraph.getDestinationXCalls(txIdsByDestinationDomain, allTxById);
if (transfers.length === 0) {
logger.debug("No pending transfers after filtering destination", requestContext, methodContext, {
Expand Down Expand Up @@ -188,15 +199,25 @@ export const getMissingXCalls = async () => {
const txIdsByDestinationDomain: Map<string, string[]> = new Map();
const allTxById: Map<string, XTransfer> = new Map();
for (const originTransfer of transfersByNonces) {
logger.debug("Processing missing transfer", requestContext, methodContext, {
logger.debug("Processing a missing transfer", requestContext, methodContext, {
transferId: originTransfer.transferId,
});

if (noncesByDomain[originTransfer.xparams.originDomain]) {
noncesByDomain[originTransfer.xparams.originDomain].push(originTransfer.xparams.nonce);
} else {
noncesByDomain[originTransfer.xparams.originDomain] = [originTransfer.xparams.nonce];
}

if (!allowedDomains.includes(originTransfer.xparams.destinationDomain)) {
logger.debug("Skipping to query a destination transfer", requestContext, methodContext, {
transferId: originTransfer.transferId,
destinationDomain: originTransfer.xparams.destinationDomain,
allowedDomains,
});
continue;
}

if (txIdsByDestinationDomain.has(originTransfer.xparams.destinationDomain)) {
txIdsByDestinationDomain.get(originTransfer.xparams.destinationDomain)?.push(`"${originTransfer.transferId}"`);
} else {
Expand Down