Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cloudflare workers example #1068

Merged
merged 13 commits into from
Oct 5, 2023
Merged

Add a cloudflare workers example #1068

merged 13 commits into from
Oct 5, 2023

Conversation

srikrsna-buf
Copy link
Member

Add a cloudflare workers example.

@srikrsna-buf srikrsna-buf requested a review from smaye81 October 4, 2023 09:22
@srikrsna-buf srikrsna-buf requested a review from timostamm October 5, 2023 06:10
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great practical example 👍

IMO it's fine to merge this as is and update once we have a server plugin package for cloudflare. I think it's also fine to add it to the top-level README.md, so we don't forget 🙂

Left just a couple of comments regarding the use-facing API.

cloudflare-workers/src/worker-handler.ts Outdated Show resolved Hide resolved
cloudflare-workers/src/worker-handler.ts Outdated Show resolved Hide resolved
cloudflare-workers/src/index.ts Outdated Show resolved Hide resolved
cloudflare-workers/package.json Show resolved Hide resolved
@srikrsna-buf srikrsna-buf requested a review from timostamm October 5, 2023 13:28
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's add this to the top-level readme too.

@srikrsna-buf srikrsna-buf merged commit 8412f40 into main Oct 5, 2023
@srikrsna-buf srikrsna-buf deleted the sk/cloudflare-workers branch October 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants