Capture unexpected io.EOF errors as io.ErrUnexpectedEOF #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
929c254 to
dc18bf1
Compare
jchadwick-buf
approved these changes
Jun 27, 2023
|
@jchadwick-buf we do handle partial frames, this seems like an issue with request streams being able to close without a flag message but response streams should always have a final flagged end response. |
|
@jchadwick-buf not sure if we already have error testing around it but added two: partial message and partial frame. Fixed partial frame error message. |
jchadwick-buf
approved these changes
Jun 27, 2023
67775d4 to
849635c
Compare
|
Is the error code the same for all three RPC protocols? I think we'll end up with |
emcfarlane
referenced
this pull request
Jul 11, 2023
For connect and gRPC-web on receiving end of stream payloads ensure no extra data is written by draining the reader and erroring on more data. Extension of https://github.com/bufbuild/connect-go/pull/533 Fixes https://github.com/bufbuild/connect-go/issues/427
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Capture unexpected io.EOF errors as io.ErrUnexpectedEOF in client streams. Now raises an error when the stream doesn't end with an end response message. Fixes https://github.com/bufbuild/connect-go/issues/397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unmarshal we return
io.EOFif there is no envelope header. TheerrSpecialEnvelopewrapsio.EOFand is used in client code to check for stream errors. To distinguish between them we can instead check onReceivestreams if the error is not a knownerrSpecialEnvelopeand return anio.ErrUnexpectedEOF.Fixes https://github.com/bufbuild/connect-go/issues/397