Implement fmt.Stringer interface for StreamType #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I started porting/writing a logging interceptor at github.com/svrana/go-connect-middleware and it'd be nice to be able output the StreamType as a string as is done in the grpc version of this code. Course I could do that in my own project, but thought it might generally be useful. |
|
I'm not sure we want to do this for this single enum - we'll discuss if we want to expose |
bufdev
reviewed
Apr 10, 2023
| case StreamTypeBidi: | ||
| return "bidi" | ||
| } | ||
| return fmt.Sprintf("stream_%d", s) |
There was a problem hiding this comment.
If we do do this, generally we've just done strconv.Itoa(int(s)) for these cases
|
@svrana I'm going to reopen this, tack on a few commits, and get this merged in :) |
akshayjshah
approved these changes
May 10, 2023
There was a problem hiding this comment.
This looks good to me. Thanks for following the example of Code so closely, @svrana!
renovate bot
referenced
this pull request
in open-feature/flagd
May 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bufbuild/connect-go](https://togithub.com/bufbuild/connect-go) | require | minor | `v1.7.0` -> `v1.8.0` | --- ### Release Notes <details> <summary>bufbuild/connect-go</summary> ### [`v1.8.0`](https://togithub.com/bufbuild/connect-go/releases/tag/v1.8.0) [Compare Source](https://togithub.com/bufbuild/connect-go/compare/v1.7.0...v1.8.0) #### What's Changed ##### Enhancements - Expose HTTP method of unary requests (see [documentation][http-method-docs]) by [@​jhump](https://togithub.com/jhump) and [@​akshayjshah](https://togithub.com/akshayjshah) in [https://github.com/bufbuild/connect-go/pull/502](https://togithub.com/bufbuild/connect-go/pull/502) and [https://github.com/bufbuild/connect-go/pull/509](https://togithub.com/bufbuild/connect-go/pull/509) - Implement `fmt.Stringer` interface for StreamType to improve debug logging by [@​svrana](https://togithub.com/svrana) in [https://github.com/bufbuild/connect-go/pull/495](https://togithub.com/bufbuild/connect-go/pull/495) ##### Bugfixes - Fix documentation comments to use correct identifier name by [@​cuishuang](https://togithub.com/cuishuang) in [https://github.com/bufbuild/connect-go/pull/498](https://togithub.com/bufbuild/connect-go/pull/498) - Fix Makefile quotes to handle paths with spaces by [@​bufdev](https://togithub.com/bufdev) in [https://github.com/bufbuild/connect-go/pull/508](https://togithub.com/bufbuild/connect-go/pull/508) - Always close response body in `CloseRead` by [@​pkwarren](https://togithub.com/pkwarren) in [https://github.com/bufbuild/connect-go/pull/515](https://togithub.com/bufbuild/connect-go/pull/515) #### New Contributors - [@​cuishuang](https://togithub.com/cuishuang) made their first contribution in [https://github.com/bufbuild/connect-go/pull/498](https://togithub.com/bufbuild/connect-go/pull/498) - [@​svrana](https://togithub.com/svrana) made their first contribution in [https://github.com/bufbuild/connect-go/pull/495](https://togithub.com/bufbuild/connect-go/pull/495) **Full Changelog**: bufbuild/connect-go@v1.7.0...v1.8.0 [http-method-docs]: https://connect.build/docs/go/get-requests-and-caching#distinguishing-get-requests </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
Following the example of `Code`, implement `fmt.Stringer` for `StreamType`. This makes it easier to use stream types in logs, traces, metric tags, and the like. Co-authored-by: Akshay Shah <akshayjshah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of
Code, implementfmt.StringerforStreamType. This makes it easier to use stream types in logs, traces, metric tags, and the like.