Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add API to make it easier to work with ErrorDetail if you have/want an Any #409

Merged
merged 5 commits into from
Dec 1, 2022
Merged

add API to make it easier to work with ErrorDetail if you have/want an Any #409

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
180f5af
add API to make it easier to work with ErrorDetail if you have/want a…
jhump Dec 1, 2022
3614139
Merge branch 'main' into jh/easier-error-details
jhump Dec 1, 2022
8d36eab
smaller surface area
jhump Dec 1, 2022
852ee1f
review feedback: document behavior in the face of an Any; provide hyp…
jhump Dec 1, 2022
33c813f
fix typo
jhump Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,14 @@ type ErrorDetail struct {
wireJSON string // preserve human-readable JSON
}

// NewErrorDetail constructs a new error detail.
// NewErrorDetail constructs a new error detail. If msg is an *[anypb.Any] then
// it is used as is. Otherwise, it is first marshalled into an *[anypb.Any]
// value. This returns an error if msg cannot be marshalled.
func NewErrorDetail(msg proto.Message) (*ErrorDetail, error) {
// If it's already an Any, don't wrap it inside another.
if pb, ok := msg.(*anypb.Any); ok {
return &ErrorDetail{pb: pb}, nil
}
pb, err := anypb.New(msg)
if err != nil {
return nil, err
Expand Down