Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to gRPC server transcoding #478

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ dockercomposetestgo: dockercomposeclean
docker-compose run client-connect-go-to-server-connect-go-h3
docker-compose run client-connect-go-to-server-connect-node-fastify-h1
docker-compose run client-connect-go-to-server-connect-node-fastify-h2
docker-compose run client-connect-go-to-server-grpc-adapter-h1
docker-compose run client-connect-go-to-server-grpc-adapter-h2
docker-compose run client-connect-go-grpc-to-server-connect-node-fastify-h1
docker-compose run client-connect-go-grpc-to-server-connect-node-fastify-h2
docker-compose run client-connect-go-grpc-web-to-server-connect-node-fastify-h1
Expand All @@ -98,10 +100,12 @@ dockercomposetestgo: dockercomposeclean
docker-compose run client-connect-go-grpc-web-to-envoy-server-connect-go-h1
docker-compose run client-connect-go-grpc-web-to-envoy-server-grpc-go-h1
docker-compose run client-connect-go-grpc-web-to-envoy-server-connect-node-fastify-h1
docker-compose run client-connect-go-grpc-web-to-server-grpc-adapter-h2
docker-compose run client-connect-go-grpc-to-server-grpc-go
docker-compose run client-grpc-go-to-server-connect-go
docker-compose run client-grpc-go-to-server-grpc-go
docker-compose run client-grpc-go-to-server-connect-node-fastify

$(MAKE) dockercomposeclean

.PHONY: dockercomposetestweb
Expand Down
2 changes: 1 addition & 1 deletion cmd/client/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func bind(cmd *cobra.Command, flags *flags) error {
"i",
"",
fmt.Sprintf(
"the client implementation tested, accepted values are %q, %q, %q, %q, %q, %q, %q, %q, or %q",
"the client implementation tested, accepted values are %q, %q, %q, %q, %q, %q, %q, %q or %q",
connectH1,
connectH2,
connectH3,
Expand Down
51 changes: 43 additions & 8 deletions cmd/servergrpc/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,31 +17,41 @@ package main
import (
"crypto/tls"
"crypto/x509"
"errors"
"fmt"
"log"
"net"
"net/http"
"os"
"os/signal"
"syscall"
"time"

testrpc "github.com/bufbuild/connect-crosstest/internal/gen/proto/go/grpc/testing"
serverpb "github.com/bufbuild/connect-crosstest/internal/gen/proto/go/server/v1"
"github.com/bufbuild/connect-crosstest/internal/interop/interopgrpc"
"github.com/bufbuild/connect-go/grpcadapter"
"github.com/spf13/cobra"
"golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials"
_ "google.golang.org/grpc/encoding/gzip" // this register the gzip compressor to the grpc server
"google.golang.org/protobuf/encoding/protojson"
)

const (
portFlagName = "port"
certFlagName = "cert"
keyFlagName = "key"
portFlagName = "port"
adapterPortFlagName = "adapterport"
certFlagName = "cert"
keyFlagName = "key"
)

type flags struct {
port string
certFile string
keyFile string
port string
adapterPort string
certFile string
keyFile string
}

func main() {
Expand All @@ -61,6 +71,7 @@ func main() {

func bind(cmd *cobra.Command, flagset *flags) error {
cmd.Flags().StringVar(&flagset.port, portFlagName, "", "the port the server will listen on")
cmd.Flags().StringVar(&flagset.adapterPort, adapterPortFlagName, "", "port for gRPC adapter traffic")
cmd.Flags().StringVar(&flagset.certFile, certFlagName, "", "path to the TLS cert file")
cmd.Flags().StringVar(&flagset.keyFile, keyFlagName, "", "path to the TLS key file")
for _, requiredFlag := range []string{portFlagName, certFlagName, keyFlagName} {
Expand Down Expand Up @@ -100,8 +111,22 @@ func run(flagset *flags) {
}
_, _ = fmt.Fprintln(os.Stdout, string(bytes))
testrpc.RegisterTestServiceServer(server, interopgrpc.NewTestServer())
_ = server.Serve(lis)
defer server.GracefulStop()

adapterServer := newAdapterServer(flagset, server)

done := make(chan os.Signal, 1)
signal.Notify(done, os.Interrupt, syscall.SIGINT, syscall.SIGTERM)
go func() {
err := adapterServer.ListenAndServeTLS(flagset.certFile, flagset.keyFile)
if err != nil && !errors.Is(err, http.ErrServerClosed) {
log.Fatalln(err)
}
}()
go func() {
_ = server.Serve(lis)
}()
<-done
server.GracefulStop()
}

func newTLSConfig(certFile, keyFile string) *tls.Config {
Expand All @@ -121,3 +146,13 @@ func newTLSConfig(certFile, keyFile string) *tls.Config {
RootCAs: caCertPool,
}
}

func newAdapterServer(flags *flags, server *grpc.Server) *http.Server {
handler := grpcadapter.NewHandler(server)
adapterServer := &http.Server{
Addr: ":" + flags.adapterPort,
ReadHeaderTimeout: 3 * time.Second,
}
adapterServer.Handler = h2c.NewHandler(handler, &http2.Server{})
return adapterServer
}
30 changes: 29 additions & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ services:
dockerfile: Dockerfile.crosstestgo
args:
TEST_CONNECT_GO_BRANCH: "${TEST_CONNECT_GO_BRANCH:-}"
entrypoint: /usr/local/bin/servergrpc --port "8083" --cert "cert/server-grpc.crt" --key "cert/server-grpc.key"
entrypoint: /usr/local/bin/servergrpc --port "8083" --adapterport "8085" --cert "cert/server-grpc.crt" --key "cert/server-grpc.key"
ports:
- "8083:8083"
- "8085:8085"
server-connect-node-fastify:
build:
context: .
Expand Down Expand Up @@ -225,6 +226,33 @@ services:
entrypoint: /usr/local/bin/client --host="server-grpc" --port="8083" --implementation="connect-grpc-h2" --cert "cert/client.crt" --key "cert/client.key"
depends_on:
- server-grpc
client-connect-go-to-server-grpc-adapter-h1:
build:
context: .
dockerfile: Dockerfile.crosstestgo
args:
TEST_CONNECT_GO_BRANCH: "${TEST_CONNECT_GO_BRANCH:-}"
entrypoint: /usr/local/bin/client --host="server-grpc" --port="8085" --implementation="connect-h1" --cert "cert/client.crt" --key "cert/client.key"
depends_on:
- server-grpc
client-connect-go-to-server-grpc-adapter-h2:
build:
context: .
dockerfile: Dockerfile.crosstestgo
args:
TEST_CONNECT_GO_BRANCH: "${TEST_CONNECT_GO_BRANCH:-}"
entrypoint: /usr/local/bin/client --host="server-grpc" --port="8085" --implementation="connect-h2" --cert "cert/client.crt" --key "cert/client.key"
depends_on:
- server-grpc
client-connect-go-grpc-web-to-server-grpc-adapter-h2:
build:
context: .
dockerfile: Dockerfile.crosstestgo
args:
TEST_CONNECT_GO_BRANCH: "${TEST_CONNECT_GO_BRANCH:-}"
entrypoint: /usr/local/bin/client --host="server-grpc" --port="8085" --implementation="connect-grpc-web-h2" --cert "cert/client.crt" --key "cert/client.key"
depends_on:
- server-grpc
client-grpc-go-to-server-connect-go:
build:
context: .
Expand Down
10 changes: 5 additions & 5 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ module github.com/bufbuild/connect-crosstest
go 1.18

require (
github.com/bufbuild/connect-go v1.9.0
github.com/bufbuild/connect-go v1.9.1-0.20230630154638-574b6cb367e3
github.com/quic-go/quic-go v0.33.0
github.com/rs/cors v1.8.3
github.com/spf13/cobra v1.6.1
github.com/stretchr/testify v1.8.2
golang.org/x/net v0.8.0
golang.org/x/net v0.11.0
google.golang.org/grpc v1.53.0
google.golang.org/protobuf v1.31.0
)
Expand All @@ -27,11 +27,11 @@ require (
github.com/quic-go/qtls-go1-19 v0.2.1 // indirect
github.com/quic-go/qtls-go1-20 v0.1.1 // indirect
github.com/spf13/pflag v1.0.5 // indirect
golang.org/x/crypto v0.6.0 // indirect
golang.org/x/crypto v0.10.0 // indirect
golang.org/x/exp v0.0.0-20230213192124-5e25df0256eb // indirect
golang.org/x/mod v0.8.0 // indirect
golang.org/x/sys v0.6.0 // indirect
golang.org/x/text v0.8.0 // indirect
golang.org/x/sys v0.9.0 // indirect
golang.org/x/text v0.10.0 // indirect
golang.org/x/tools v0.6.0 // indirect
google.golang.org/genproto v0.0.0-20230221151758-ace64dc21148 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Expand Down
24 changes: 10 additions & 14 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
github.com/bufbuild/connect-go v1.7.0 h1:MGp82v7SCza+3RhsVhV7aMikwxvI3ZfD72YiGt8FYJo=
github.com/bufbuild/connect-go v1.7.0/go.mod h1:GmMJYR6orFqD0Y6ZgX8pwQ8j9baizDrIQMm1/a6LnHk=
github.com/bufbuild/connect-go v1.9.0 h1:JIgAeNuFpo+SUPfU19Yt5TcWlznsN5Bv10/gI/6Pjoc=
github.com/bufbuild/connect-go v1.9.0/go.mod h1:CAIePUgkDR5pAFaylSMtNK45ANQjp9JvpluG20rhpV8=
github.com/bufbuild/connect-go v1.9.1-0.20230630154638-574b6cb367e3 h1:c84rcZWYmgiDnEQhgx8CHEKKfoPNkg1V5SSU6ree0vE=
github.com/bufbuild/connect-go v1.9.1-0.20230630154638-574b6cb367e3/go.mod h1:dg3XQQDFUWdXW/RQ4/J3/W5CO/WEsjeSUrALQw0uLt4=
github.com/cpuguy83/go-md2man/v2 v2.0.2/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
Expand Down Expand Up @@ -62,8 +60,8 @@ github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o
github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
golang.org/x/crypto v0.6.0 h1:qfktjS5LUO+fFKeJXZ+ikTRijMmljikvG68fpMMruSc=
golang.org/x/crypto v0.6.0/go.mod h1:OFC/31mSvZgRz0V1QTNCzfAI1aIRzbiufJtkMIlEp58=
golang.org/x/crypto v0.10.0 h1:LKqV2xt9+kDzSTfOhx4FrkEBcMrAgHSYgzywV9zcGmM=
golang.org/x/crypto v0.10.0/go.mod h1:o4eNf7Ede1fv+hwOwZsTHl9EsPFO6q6ZvYR8vYfY45I=
golang.org/x/exp v0.0.0-20230213192124-5e25df0256eb h1:PaBZQdo+iSDyHT053FjUCgZQ/9uqVwPOcl7KSWhKn6w=
golang.org/x/exp v0.0.0-20230213192124-5e25df0256eb/go.mod h1:CxIveKay+FTh1D0yPZemJVgC/95VzuuOLq5Qi4xnoYc=
golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
Expand All @@ -72,22 +70,22 @@ golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
golang.org/x/net v0.8.0 h1:Zrh2ngAOFYneWTAIAPethzeaQLuHwhuBkuV6ZiRnUaQ=
golang.org/x/net v0.8.0/go.mod h1:QVkue5JL9kW//ek3r6jTKnTFis1tRmNAW2P1shuFdJc=
golang.org/x/net v0.11.0 h1:Gi2tvZIJyBtO9SDr1q9h5hEQCp/4L2RQ+ar0qjx2oNU=
golang.org/x/net v0.11.0/go.mod h1:2L/ixqYpgIVXmeoSA/4Lu7BzTG4KIyPIryS4IsOd1oQ=
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.6.0 h1:MVltZSvRTcU2ljQOhs94SXPftV6DCNnZViHeQps87pQ=
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.9.0 h1:KS/R3tvhPqvJvwcKfnBHJwwthS11LRhmM5D59eEXa0s=
golang.org/x/sys v0.9.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.8.0 h1:57P1ETyNKtuIjB4SRd15iJxuhj8Gc416Y78H3qgMh68=
golang.org/x/text v0.8.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
golang.org/x/text v0.10.0 h1:UpjohKhiEgNc0CSauXmwYftY1+LlaC75SJwh0SgCX58=
golang.org/x/text v0.10.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
golang.org/x/tools v0.1.1/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
Expand All @@ -103,8 +101,6 @@ google.golang.org/grpc v1.53.0 h1:LAv2ds7cmFV/XTS3XG1NneeENYrXGmorPxsBbptIjNc=
google.golang.org/grpc v1.53.0/go.mod h1:OnIrk0ipVdj4N5d9IUoFUx72/VlD7+jUsHwZgwSMQpw=
google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=
google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
google.golang.org/protobuf v1.28.1 h1:d0NfwRgPtno5B1Wa6L2DAG+KivqkdutMf1UhdNx175w=
google.golang.org/protobuf v1.28.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
google.golang.org/protobuf v1.31.0 h1:g0LDEJHgrBl9N9r17Ru3sqWhkIx2NB67okBHPwC7hs8=
google.golang.org/protobuf v1.31.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
Expand Down