Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-wrapper: add AUTH_WRAPPER_QUIET env support #6

Merged
merged 8 commits into from
Jun 23, 2022

Conversation

Viterkim
Copy link
Contributor

Going to be used in device-debug tools since we just want the output (and exit code is tranmitted normally).

People around the office are getting agent 27: ssh: parse error in message type 27 everytime we call auth-wrapper. And i can't figure out how to debug it since i get
runCommandWithSSHAgent: cmd.Start: exec: "ssh support@192.168.7.1 'echo hello'": executable file not found in $PATH when running with debugger / a local compile. (And i don't really know Go enough for :D)

Would be nice to get the last error silenced as well.

@Viterkim Viterkim requested a review from tlbdk June 16, 2022 15:18
@@ -30,6 +30,7 @@ type Config struct {
SSHCaAuthorizedKeysPath string
SSHSigningServerAddress string
SSHAgentSocket string
AuthWrapperQuiet string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a Boolean value

@@ -0,0 +1,13 @@
# Usage Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to main readme

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Viterkim
Copy link
Contributor Author

Moved it

@Viterkim Viterkim merged commit 5ea7294 into master Jun 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the auth-wrapper-quiet branch June 23, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants