-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: add mixins to make sure cn_mail does not send additional he…
…ader imapuser expects no additional headers with extjs-app-webmail#255 refs conjoon/extjs-app-webmail#255
- Loading branch information
1 parent
f0acfb2
commit 5969e5f
Showing
13 changed files
with
231 additions
and
32 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...coon/user/view/authentication/AuthForm.js → ...coon.user.view.authentication.AuthForm.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * conjoon | ||
| * extjs-app-imapuser | ||
| * Copyright (C) 2022 Thorsten Suckow-Homberg https://github.com/conjoon/extjs-app-imapuser | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person | ||
| * obtaining a copy of this software and associated documentation | ||
| * files (the "Software"), to deal in the Software without restriction, | ||
| * including without limitation the rights to use, copy, modify, merge, | ||
| * publish, distribute, sublicense, and/or sell copies of the Software, | ||
| * and to permit persons to whom the Software is furnished to do so, | ||
| * subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included | ||
| * in all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
| * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | ||
| * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| * USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| /** | ||
| * | ||
| * | ||
| */ | ||
| Ext.define("conjoon.cn_imapuser.overrides.conjoon.cn_mail.data.mail.HeaderMixin", { | ||
|
|
||
| override: "conjoon.cn_mail.data.mail.HeaderMixin", | ||
|
|
||
| getAdditionalHeaders (url, cfg) { | ||
| return {}; | ||
| }, | ||
|
|
||
|
|
||
| getConnectionHeaders (url) { | ||
| return {}; | ||
| }, | ||
|
|
||
| getAuthHeaders (url, type) { | ||
| return {}; | ||
| }, | ||
|
|
||
|
|
||
| /** | ||
| * @param url | ||
| * @returns {conjoon.cn_mail.model.mail.folder.MailFolder|null} | ||
| * @private | ||
| */ | ||
| getAccountForUrl (url) { | ||
| throw new Error("Runtime Exception: getAccoutnUrl should not be called from extern."); | ||
| } | ||
|
|
||
| }); |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * conjoon | ||
| * extjs-app-imapuser | ||
| * Copyright (C) 2022 Thorsten Suckow-Homberg https://github.com/conjoon/extjs-app-imapuser | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person | ||
| * obtaining a copy of this software and associated documentation | ||
| * files (the "Software"), to deal in the Software without restriction, | ||
| * including without limitation the rights to use, copy, modify, merge, | ||
| * publish, distribute, sublicense, and/or sell copies of the Software, | ||
| * and to permit persons to whom the Software is furnished to do so, | ||
| * subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included | ||
| * in all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
| * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | ||
| * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| * USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| Ext.define("conjoon.cn_imapuser.overrides.conjoon.dev.cn_mailsim.data.HeaderMixin", { | ||
|
|
||
| override: "conjoon.dev.cn_mailsim.data.HeaderMixin", | ||
|
|
||
| checkHeader: function (xhr) { | ||
| return true; | ||
| }, | ||
|
|
||
|
|
||
| matchAccountInfoForCurrentRequest (mailAccountId) { | ||
| return true; | ||
| } | ||
| }); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
tests/overrides/conjoon.cn_mail.data.mail.HeaderMixinTest.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /** | ||
| * conjoon | ||
| * extjs-app-imapuser | ||
| * Copyright (C) 2022 Thorsten Suckow-Homberg https://github.com/conjoon/extjs-app-imapuser | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person | ||
| * obtaining a copy of this software and associated documentation | ||
| * files (the "Software"), to deal in the Software without restriction, | ||
| * including without limitation the rights to use, copy, modify, merge, | ||
| * publish, distribute, sublicense, and/or sell copies of the Software, | ||
| * and to permit persons to whom the Software is furnished to do so, | ||
| * subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included | ||
| * in all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
| * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | ||
| * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| * USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| StartTest(t => { | ||
|
|
||
|
|
||
| t.requireOk( | ||
| "conjoon.cn_mail.data.mail.HeaderMixin", | ||
| "conjoon.cn_imapuser.overrides.conjoon.cn_mail.data.mail.HeaderMixin", () => { | ||
|
|
||
| const makeMixin = () => Ext.create("conjoon.cn_mail.data.mail.HeaderMixin"); | ||
|
|
||
| t.it("getAdditionalHeaders()", t => { | ||
| t.expect(makeMixin().getAdditionalHeaders()).toEqual({}); | ||
| }); | ||
|
|
||
| t.it("getConnectionHeaders()", t => { | ||
| t.expect(makeMixin().getConnectionHeaders()).toEqual({}); | ||
| }); | ||
|
|
||
| t.it("getAuthHeaders()", t => { | ||
| t.expect(makeMixin().getAuthHeaders()).toEqual({}); | ||
| }); | ||
|
|
||
| }); | ||
|
|
||
| }); |
File renamed without changes.
46 changes: 46 additions & 0 deletions
46
tests/overrides/conjoon.dev.cn_mailsim.data.HeaderMixinTest.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /** | ||
| * conjoon | ||
| * extjs-app-imapuser | ||
| * Copyright (C) 2022 Thorsten Suckow-Homberg https://github.com/conjoon/extjs-app-imapuser | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person | ||
| * obtaining a copy of this software and associated documentation | ||
| * files (the "Software"), to deal in the Software without restriction, | ||
| * including without limitation the rights to use, copy, modify, merge, | ||
| * publish, distribute, sublicense, and/or sell copies of the Software, | ||
| * and to permit persons to whom the Software is furnished to do so, | ||
| * subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included | ||
| * in all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
| * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | ||
| * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| * USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| StartTest(t => { | ||
|
|
||
|
|
||
| t.requireOk( | ||
| "conjoon.cn_imapuser.overrides.conjoon.dev.cn_mailsim.data.HeaderMixin", | ||
| "conjoon.dev.cn_mailsim.data.HeaderMixin", () => { | ||
|
|
||
| const makeMixin = () => Ext.create("conjoon.dev.cn_mailsim.data.HeaderMixin"); | ||
|
|
||
| t.it("checkHeader()", t => { | ||
| t.expect(makeMixin().checkHeader()).toBe(true); | ||
| }); | ||
|
|
||
|
|
||
| t.it("matchAccountInfoForCurrentRequest()", t => { | ||
| t.expect(makeMixin().matchAccountInfoForCurrentRequest()).toBe(true); | ||
| }); | ||
|
|
||
| }); | ||
|
|
||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,4 +49,4 @@ StartTest(t => { | |
|
|
||
| }); | ||
|
|
||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters