Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another take on MicrowavePowerTransmitter #18

Merged
merged 1 commit into from
Aug 17, 2014
Merged

Another take on MicrowavePowerTransmitter #18

merged 1 commit into from
Aug 17, 2014

Conversation

rakkhin
Copy link

@rakkhin rakkhin commented Aug 17, 2014

Switched MicrowavePowerTransmitter power reservation from FNFusionReactor.powerRequirements to ORSResourceManager.PowerDraws (new read-only property exposing internal power_draw_list_archive).

Disallowed activating more than one MicrowavePowerTransmitter in transmitter mode (more than one relay is still allowed) as that causes trouble with power balancing between them, with two transmitters they will eventually reach equilibrium but any external change in power draw (eg. activating Science Lab) will throw them off balance, switching one transmitter on and off is required to regain balance, with more than two balance was never reached, and since having more than one transmitter shouldn't increase vessel's beamed power output and transmitter's size and orientation has no meaning for its performance, allowing more transmitters doesn't really have any sense.

Tested with:

  • 2 Fusion Reactors, 4 Generators, 1 Science Lab switching Antimatter production on/off, 1 Computer Core, 1 Transmitter, ended up with positive power supply of 0.3 KW
  • 2 Fusion Reactors, 4 Generators, 1 Science Lab switching Antimatter production on/off, 1 Computer Core, 2 Transmitters (reached equilibrium after ~3 sec. with positive power supply of 0.3 KW, required toggling of one transmitter every time Science Lab was switched on or off)
  • 2 Fusion Reactors, 4 Generators, 1 Science Lab, 1 Computer Core, 4 Transmitters (after enabling 3rd transmitter equilibrium was never reached, that's why I disabled more than one transmitter)

Signed-off-by: Tomasz Majer tomkuzyno@gmail.com

…ctor powerRequirements to ORSResourceManager PowerDraws (new read-only property exposing internal power_draw_list_archive)

- Disallow activating more than one MicrowavePowerTransmitter in transmitter mode (more than one relay is still allowed) as that causes trouble with power balancing, with two transmitters they will eventually reach equilibrium but any external change in power draw (eg. activating Science Lab) will throw them off balance, switching one transmitter on and off is required to regain balance, and since having more than one transmitter shouldn't increase vessel's beamed power output, allowing more transmitters doesn't really have any sense

Signed-off-by: Tomasz Majer <tomkuzyno@gmail.com>
@rakkhin rakkhin changed the title Final take on MicrowavePowerTransmitter Another take on MicrowavePowerTransmitter Aug 17, 2014
confusingbits pushed a commit that referenced this pull request Aug 17, 2014
Another take on MicrowavePowerTransmitter
@confusingbits confusingbits merged commit a440566 into confusingbits:development Aug 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants