Power generation from mixed mode reactors/minor power transmission fix #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when reactors are producing both Thermal Power and Charged Particles attached generators read wrong Thermal Power value from reactors as if reactor generated his full potential power as Thermal Power Fix Thermal Generators eating Charged Particles - it is normal, that Thermal generators can use Charged Particles to generate power if Direct Conversion Generator is not present or disabled, that should not be the case, Thermal Generators should use only Thermal Power Fix Direct Conversion Generators being able to exceed their capabilities - when there's more than one Direct Conversion Generator (as if with more than one Fusion Reactor in mixed mode for example) occasionally one of them can use all Charged Particles and exceed its maximum capacity without any drawbacks (same happens when one of generators is shut down) Fix Microwave Transceivers power reservation for Fusion Reactors, switch from "magic numbers" to actual value - 0.95 is some number, what it means? where it came from? better solution is to use value provided by FNFusionReactor itself. Signed-off-by: Tomasz Majer <tomkuzyno@gmail.com>
confusingbits
pushed a commit
that referenced
this pull request
Aug 16, 2014
Power generation from mixed mode reactors/minor power transmission fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Reactors reporting wrong Thermal Power value when in mixed mode - when reactors are producing both Thermal Power and Charged Particles attached generators read wrong Thermal Power value from reactors as if reactor generated his full potential power as Thermal Power
Fix Thermal Generators eating Charged Particles - it is normal, that Thermal generators can use Charged Particles to generate power if Direct Conversion Generator is not present or disabled, that should not be the case, Thermal Generators should use only Thermal Power
Fix Direct Conversion Generators being able to exceed their capabilities - when there's more than one Direct Conversion Generator (as if with more than one Fusion Reactor in mixed mode for example) occasionally one of them can use all Charged Particles and exceed its maximum capacity without any drawbacks (same thing happens when one of generators is shut down)
Fix Microwave Transceivers power reservation for Fusion Reactors - switch from "magic numbers" to actual value - 0.95 is some number, what it means? where it came from? better solution is to use value provided by FNFusionReactor itself.
Let me know what you think about this.
Cheers,
Signed-off-by: Tomasz Majer tomkuzyno@gmail.com