Skip to content

Commit

Permalink
[review] change javaDoc + revert un-required addition
Browse files Browse the repository at this point in the history
  • Loading branch information
sudeshwasnik committed Jan 9, 2025
1 parent c2ef317 commit 16d208a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1310,13 +1310,13 @@ public void insert(SinkRecord kafkaSinkRecord) {
}

/**
* Get all rows and their offsets. Each map corresponds to one row whose keys are column names
* and values are corresponding data in that column.
* Get all rows and corresponding SinkRecords. Each map corresponds to one row whose keys are
* column names and values are corresponding data in that column.
*
* <p>This goes over through all buffered kafka records and transforms into JsonSchema and
* JsonNode Check {@link #handleNativeRecord(SinkRecord, boolean)}
*
* @return A pair that contains the records and their corresponding offsets
* @return A pair that contains the records and their corresponding original sinkRecords
*/
@Override
public Pair<List<Map<String, Object>>, List<SinkRecord>> getData() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,7 @@ private void testInsertRowsWithGaps(boolean withSchematization, boolean useSingl
SnowflakeSinkConnectorConfig.setDefaultValues(config);
config.put(
SnowflakeSinkConnectorConfig.ENABLE_SCHEMATIZATION_CONFIG,
Boolean.toString(withSchematization)
);
Boolean.toString(withSchematization));

// create tpChannel
SnowflakeSinkService service =
Expand Down

0 comments on commit 16d208a

Please sign in to comment.