feat: add FROM_DAYS and update UNIX_DATE function #7742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
reviewed
Jun 29, 2021
JimGalasyn
reviewed
Jun 29, 2021
JimGalasyn
reviewed
Jun 29, 2021
JimGalasyn
reviewed
Jun 29, 2021
JimGalasyn
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from_days: converts number of days to a date
unix_date(date): converts a date to a number of days since epoch
Also updates the KLIP to add FROM_DAYS and cancel CONVERT_TZ and UNIX_TIME, since those aren't really implemented anywhere.
Testing done
QTT and unit tests
Reviewer checklist