feat: implement serde for DATE #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
spena
reviewed
Jun 25, 2021
| @@ -148,4 +149,18 @@ public static Time returnTimeOrThrow(final long time) { | |||
| + TimeUnit.DAYS.toMillis(1) + "."); | |||
| } | |||
| } | |||
|
|
|||
| public static Date getDateFromEpochDays(final long days) { | |||
| return new Date(TimeUnit.DAYS.toMillis(days)); | |||
There was a problem hiding this comment.
Are there issues if days is negative?
There was a problem hiding this comment.
Nope, added some negative dates to QTT tests
spena
approved these changes
Jun 25, 2021
|
Looks good then. Thanks for the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement serde for DATE. DATE gets serialized to an integer number of days since 1970-01-01, and deserialized to
java.sql.DateTesting done
unit and QTT tests
Reviewer checklist