Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement casting for DATE/TIME #7708

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Jun 21, 2021

Description

Adds casting/coercion for DATE/TIME, as well as parsers for STRING to DATE/TIME.

Testing done

Unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from spena June 21, 2021 23:38
@jzaralim jzaralim requested a review from a team as a code owner June 21, 2021 23:38
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the code looks good.

@jzaralim jzaralim merged commit 18cc030 into confluentinc:master Jun 22, 2021
@jzaralim jzaralim deleted the cast branch June 22, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants