-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extended query anonymizer tests with functional tests queries #7480
Merged
tolgadur
merged 2 commits into
confluentinc:master
from
tolgadur:extend-query-anonymizer-tests
May 13, 2021
Merged
fix: extended query anonymizer tests with functional tests queries #7480
tolgadur
merged 2 commits into
confluentinc:master
from
tolgadur:extend-query-anonymizer-tests
May 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@confluentinc It looks like @tolgadur just signed our Contributor License Agreement. 👍 Always at your service, clabot |
swist
reviewed
May 6, 2021
ksqldb-parser/src/test/java/io/confluent/ksql/util/QueryAnonymizerTest.java
Outdated
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-parser/src/main/java/io/confluent/ksql/util/QueryAnonymizer.java
Outdated
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/QueryAnonymizerTest.java
Outdated
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/QueryAnonymizerTest.java
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/QueryAnonymizerTest.java
Outdated
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/QueryAnonymizerTest.java
Outdated
Show resolved
Hide resolved
swist
reviewed
May 6, 2021
ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/QueryAnonymizerTest.java
Outdated
Show resolved
Hide resolved
e97a32e
to
53bf0f7
Compare
6e44336
to
a1868d8
Compare
f0886c4
to
c781ee8
Compare
c781ee8
to
3b63794
Compare
swist
approved these changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tests take queries used in the ksqldb functional tests to test the QueryAnonymizer and make it more robust before shipping. The issues identified and fixed are:
EXPLAIN SELECT * FROM my_table;
just resulted inEXPLAIN query;
SELECT * FROM my_table
Unfortunately with the current implementation I did not find a way to determine whether it's a stream or table in SELECT statements. Thus, the anonymizer is just using the generic 'source'. I.e.
SELECT * FROM my_table
becomesSELECT * FROM source1
.I was also not able to correctly determine the keys in JOIN statements. Thus, the anonymizer is just using the generic
key1=key2
. I.e.becomes
Reviewer checklist