Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for null inputs for various timestamp functions #7180

Merged
merged 1 commit into from
Mar 10, 2021
Merged

fix: check for null inputs for various timestamp functions #7180

merged 1 commit into from
Mar 10, 2021

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Mar 9, 2021

Description

Fixes #7160

Testing done

Updated unit and QTT tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner March 9, 2021 02:48
spena
spena approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzaralim jzaralim merged commit 42496c1 into confluentinc:master Mar 10, 2021
@jzaralim jzaralim deleted the null branch March 10, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Most of the timestamp functions throw NPE on null input
2 participants
@jzaralim @spena