fix: JSON format to set correct scale of decimals #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the responsibility of the format to ensure the data returned matches the required schema. This includes the scale of decimals. The JSON format was not correctly setting the scale of decimals when deserializing. For example, give:
```sql
CREATE STREAM S (ID INT KEY, PRICE DECIMAL(10,2) WITH (kafka_topic='S', formats='JSON');
```
The above creates a stream with a single value column `PRICE` which should have a scale of `2`, i.e. two decimal places.
If the data in tbe Kafka record's value was to have the incorrect, e.g.
```json
{
"price": 12
}
```
or
```json
{
"price": 12.1
}
```
Then the deserializer was returning the decimal as provided, i.e. `12` or `12.1`. However, this is incorrect as the schema of the column states is has a scale of two. So all values for the column should have the scale set to two, i.e. the above examples should deserialize to `12.00` and `12.10`. With this change they no do.
vcrfxia
approved these changes
Sep 28, 2020
ksqldb-serde/src/test/java/io/confluent/ksql/serde/json/KsqlJsonDeserializerTest.java
Show resolved
Hide resolved
ksqldb-serde/src/main/java/io/confluent/ksql/serde/json/KsqlJsonDeserializer.java
Show resolved
Hide resolved
agavra
pushed a commit
that referenced
this pull request
Oct 9, 2020
* fix: JSON format should correct scale of decimals when deserializing
It is the responsibility of the format to ensure the data returned matches the required schema. This includes the scale of decimals. The JSON format was not correctly setting the scale of decimals when deserializing. For example, give:
```sql
CREATE STREAM S (ID INT KEY, PRICE DECIMAL(10,2) WITH (kafka_topic='S', formats='JSON');
```
The above creates a stream with a single value column `PRICE` which should have a scale of `2`, i.e. two decimal places.
If the data in tbe Kafka record's value was to have the incorrect, e.g.
```json
{
"price": 12
}
```
or
```json
{
"price": 12.1
}
```
Then the deserializer was returning the decimal as provided, i.e. `12` or `12.1`. However, this is incorrect as the schema of the column states is has a scale of two. So all values for the column should have the scale set to two, i.e. the above examples should deserialize to `12.00` and `12.10`. With this change they no do.
Co-authored-by: Andy Coates <big-andy-coates@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is the responsibility of the format to ensure the data returned matches the required schema. This includes the scale of decimals. The JSON format was not correctly setting the scale of decimals when deserializing. For example, give:
The above creates a stream with a single value column
PRICEwhich should have a scale of2, i.e. two decimal places.If the data in tbe Kafka record's value was to have too small a scale, e.g.
{ "price": 12 }or
{ "price": 12.1 }Then the deserializer was returning the decimal as provided, i.e.
12or12.1. However, this is incorrect as the schema of the column states is has a scale of two. So all values for the column should have the scale set to two, i.e. the above examples should deserialize to12.00and12.10. With this change they now do.Testing done
Usual
Reviewer checklist