feat: Add metrics for pull query request/response size in bytes #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpapavas
commented
Sep 3, 2020
| @@ -112,6 +118,9 @@ static void handleOldApiResponse(final Server server, final RoutingContext routi | |||
| response.end(responseBody); | |||
| } | |||
| } | |||
| pullQueryMetrics | |||
There was a problem hiding this comment.
This is the only place where we have access to the response sent over the wire. That's why I had to pass the pullQueryMetrics object in here
vpapavas
commented
Sep 3, 2020
ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutor.java
Show resolved
Hide resolved
vpapavas
commented
Sep 3, 2020
| //Record latency at microsecond scale | ||
| final long nowNanos = Time.SYSTEM.nanoseconds(); | ||
| final double latency = TimeUnit.NANOSECONDS.toMicros(nowNanos - startTimeNanos); | ||
| pullQueryMetrics.get().recordLatency(latency); |
There was a problem hiding this comment.
I am not measuring the request/response here since I don't have access to the HttpServerRequest/HttpServerResponse objects here
ksqldb-rest-app/src/main/java/io/confluent/ksql/api/server/ServerVerticle.java
Outdated
Show resolved
Hide resolved
ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlServerEndpoints.java
Show resolved
Hide resolved
...rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutorMetrics.java
Outdated
Show resolved
Hide resolved
ksqldb-rest-app/src/main/java/io/confluent/ksql/api/server/OldApiUtils.java
Show resolved
Hide resolved
ksqldb-rest-app/src/main/java/io/confluent/ksql/api/impl/QueryEndpoint.java
Outdated
Show resolved
Hide resolved
ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutor.java
Show resolved
Hide resolved
...rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutorMetrics.java
Outdated
Show resolved
Hide resolved
...-app/src/test/java/io/confluent/ksql/rest/server/execution/PullQueryExecutorMetricsTest.java
Show resolved
Hide resolved
...rest-app/src/main/java/io/confluent/ksql/rest/server/execution/PullQueryExecutorMetrics.java
Show resolved
Hide resolved
ksqldb-rest-app/src/main/java/io/confluent/ksql/api/server/OldApiUtils.java
Outdated
Show resolved
Hide resolved
55cd6d7 to
db74090
Compare
AlanConfluent
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add metrics for pull query request/response size in bytes. I added it only to the
StreamedQueryResourceand not theWSQueryEndpointsince in the latter I don't have access to the vertx objects to measure their size. Also, it's not important to measure the size for queries issued from the UI editor.Testing done
Local testing with issuing pull queries and checking the value of the metrics
Reviewer checklist