Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary parser token (MINOR) #6048

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix: remove unnecessary parser token (MINOR) #6048

merged 1 commit into from
Aug 19, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Aug 19, 2020

Description

Remove unused parser token

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner August 19, 2020 15:48
big-andy-coates
big-andy-coates approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@big-andy-coates big-andy-coates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@agavra agavra merged commit a6c3864 into confluentinc:master Aug 19, 2020
@agavra agavra deleted the token_fix branch August 19, 2020 22:20
sarwarbhuiyan pushed a commit to sarwarbhuiyan/ksql that referenced this pull request Sep 4, 2020
@agavra @sarwarbhuiyan
fix: remove unnecessary parser token (confluentinc#6048)
e91fa99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-andy-coates big-andy-coates big-andy-coates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agavra @big-andy-coates