fix: Allow backported ALPN to be used and warn if no OpenSSL #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allows backported ALPN in JDK 1.8.0_252 to be used, and provide warning if openSSL is not installed
0de5079 to
42b8d55
Compare
vcrfxia
approved these changes
Jul 13, 2020
purplefox
added a commit
that referenced
this pull request
Jul 14, 2020
…allows backported ALPN in JDK 1.8.0_252 to be used, and provide warning if openSSL is not installed (#5818)
|
I have cherry-picked this to 6.0.x too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #5799
This PR:
Upgrades to Vert.x 3.9.1. This depends on Netty 4.1.49.Final which includes code which allows the backported ALPN implementation that is present in JDK 1.8.0_252 to be used. This means that if the user has configured ksqlDB for TLS and does not have OpenSSL installed and is using an up to date version of Java 8 then ksqlDB will successfully fall back to using the JDK TLS implementation and the ALPN implementation that was backported to Open JDK 1.8.0_252 from OpenJDK 9. Users with older versions of Java 8 should update their Java 8 version.
Logs a warning if OpenSSL is not installed. It's preferable to use OpenSSL for performance reasons. Most systems will have this pre-installed, but if not a warning will be logged so the user is aware of this and can install it.
Testing done
Manually tested.
Reviewer checklist