Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyless udtf #5761

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Jul 3, 2020

Description

fixes: #5723

UDTFs didn't work with new keyless streams. This change fixes this.

Plus, adds an error message if you try and create a windowed stream without a key. This previously resulted in an NPE during processing.

Testing done

usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

fixes: confluentinc#5723

UDTFs didn't work with new keyless streams. This change fixes this.

Plus, adds an error message if you try and create a windowed stream without a key. This previously resulted in an NPE during processing.
@big-andy-coates big-andy-coates requested a review from a team as a code owner July 3, 2020 13:23
@big-andy-coates big-andy-coates changed the base branch from master to 6.0.x July 3, 2020 13:24
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@big-andy-coates big-andy-coates requested a review from vpapavas July 6, 2020 15:17
@big-andy-coates big-andy-coates merged commit 190f9e2 into confluentinc:6.0.x Jul 6, 2020
@big-andy-coates big-andy-coates deleted the keyless_udtf branch July 6, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants