fix: ensure only deserializable cmds are written to command topic #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#5643 Ensures all commands written to the command topic can be deserialized before writing them. A non-deserializable command causes the command runner thread to die. Even restarting the server won't help as the server will stop when it hits the non-deserializable command again. This adds some level of protection.
stevenpyzhang
approved these changes
Jun 18, 2020
|
@big-andy-coates could you change the target branch to 6.0.x, this would be a worthwhile fix to include in that version. |
agavra
reviewed
Jun 19, 2020
Comment on lines
+73
to
+74
| * command will kill the command runner thread, this is a safety net to ensure commands written to | ||
| * the command topic can be deserialzied. |
There was a problem hiding this comment.
I suppose this isn't strictly true if the version reading is different than the version writing; but I'm not opposed to the extra safety net 😛
agavra
pushed a commit
that referenced
this pull request
Jun 19, 2020
) * fix: ensure only deserializable cmds are written to command topic fixes: #5643 Ensures all commands written to the command topic can be deserialized before writing them. A non-deserializable command causes the command runner thread to die. Even restarting the server won't help as the server will stop when it hits the non-deserializable command again. This adds some level of protection. Co-authored-by: Andy Coates <big-andy-coates@users.noreply.github.com>
rodesai
reviewed
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #5643
Ensures all commands written to the command topic can be deserialized before writing them.
A non-deserializable command causes the command runner thread to die.
Even restarting the server won't help as the server will stop when it hits the non-deserializable command again.
This adds some level of protection.
(I know I'd previously been against this, but ... meh... maybe I was wrong ;) )
Submitting a statement to the server which the server finds it can't deserialize now results in an error and the command is, importantly, not added to the command queue:
Testing done
usual
Reviewer checklist