fix: exclude window bounds from persistent query value & schema match #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#5423 fixes: confluentinc#5424 The values of `WINDOWSTART` and `WINDOWEND` should not be included in the message value on a `select *` from a windowed source. The code should also validate that the logical and physical query plan schemas _match_!
Conflicting files ksqldb-functional-tests/src/test/resources/query-validation-tests/select.json
agavra
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #5423
fixes: #5424
The values of
WINDOWSTARTandWINDOWENDshould not be included in the message value on aselect *from a windowed source.The code should also validate that the logical and physical query plan schemas match!
Note, this PR adds some more complexity around handling persistent vs push queries. But this will go again very soon.
Testing done
usual
Reviewer checklist