feat: implement earliest_by_offset() UDAF #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
reviewed
May 5, 2020
07cecf7 to
cf2d846
Compare
purplefox
approved these changes
May 12, 2020
| static final String SEQ_FIELD = "SEQ"; | ||
| static final String VAL_FIELD = "VAL"; | ||
|
|
||
| public static final Schema STRUCT_INTEGER = SchemaBuilder.struct().optional() |
There was a problem hiding this comment.
All these constants look the same as the ones in LatestbyOffset. It would be nice to move them to another shared file instead of duplicating them.
| return earliest(STRUCT_STRING); | ||
| } | ||
|
|
||
| static <T> Struct createStruct(final Schema schema, final T val) { |
There was a problem hiding this comment.
This could go in a common base class instead of duplicating (or a utils class)
| return sequence.getAndIncrement(); | ||
| } | ||
|
|
||
| private static int compareStructs(final Struct struct1, final Struct struct2) { |
There was a problem hiding this comment.
This could go in common class too.
spena
added a commit
to spena/ksql
that referenced
this pull request
May 14, 2020
spena
added a commit
that referenced
this pull request
May 14, 2020
purplefox
reviewed
May 16, 2020
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package io.confluent.ksql.function.udaf; |
There was a problem hiding this comment.
Imho we should create a directory and put both udafs and this file in the same package. That way it can be package protected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5268
Implements earliest_by_offset() UDAF which computes the earliest value for a column. Earliest being defined as offset order.
Note for the reviewer:
Testing done
Added new unit test and QTT test
Reviewer checklist